-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure SDK. #47140
Update Azure SDK. #47140
Conversation
ugh, something is broken here... |
34350dd
to
66e9eb5
Compare
eca63cb
to
5c6bc46
Compare
/retest |
1 similar comment
/retest |
@jbeda this is good to go (once a flaky tests passes) can I get an LGTM? |
995c14f
to
c186419
Compare
@rootfs @colemickens @jbeda This is ready to go (again), can I get an LGTM? There is nothing here except SDK updates and necessary small changes to the azure client code. Thanks! |
/lgtm thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, jbeda, rootfs Associated issue requirement bypassed by: brendandburns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 48672, 47140, 48709, 48786, 48757) |
I think this may have broken the crossbuild. From https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-cross-build/2320/:
|
looks like moby/moby@fab67ab made it into docker v1.12, but we vendor v1.11. :\ |
Automatic merge from submit-queue (batch tested with PRs 48997, 48595, 48898, 48711, 48972) Revert "Use go-ansiterm version matching docker/pkg/term/windows v1.11" This reverts commit 72044a1. **What this PR does / why we need it**: earlier this week, #47140 updated the vendored azure dependencies, which broke the windows build because the docker dependencies were too old. #48933 was merged, which reverted part of #47140 and fixed the build, but then #48308, which updated the vendored docker dependencies, broke the windows build again. By reverting #48933, we should get back to a working build, I hope. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48887 **Release note**: ```release-note NONE ``` /release-note-none /test pull-kubernetes-cross /assign @brendandburns cc @karataliu @yguo0905 @yujuhong @dchen1107
Updates to the Azure SDK to pick up new APIs.